Fix StripeError http_body #1435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xavdid-stripe
left a comment
xavdid-stripe
left a comment
There was a problem hiding this comment.
looks good! have an extra line you should pull before merge, but approved otherwise
removed extraneous pass
xavdid-stripe
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
See #1432. There was a bug introduced in v7.1 of the SDK where the unprocessed http body passed into a Stripe error was not correctly set into the
http_bodyproperty.What?
Changelog
http_bodymay be null in a Stripe error even whenjson_bodyis a valid dictionary.