Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Orders to use qualified name for upload_api_base #782

Conversation

pakrym-stripe
Copy link
Contributor

Our test infrastructure depends on the ability to mutate upload_api_base in tests. Direct import prevented tests from switching upload_api_base to stripe-mock endpoint and tests are failing.

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's change the title to say "Revert Orders to use qualified name for upload_api_base" - no need to include codegen in the title.

@pakrym-stripe pakrym-stripe changed the title Revert Orders codegen to use qualified name for upload_api_base Revert Orders to use qualified name for upload_api_base Mar 25, 2022
@pakrym-stripe pakrym-stripe reopened this Mar 25, 2022
@pakrym-stripe pakrym-stripe merged commit 5b0c253 into master Mar 25, 2022
@remi-stripe remi-stripe deleted the pakrym/Revert_Orders_codegen_to_use_qualified_name_for_upload_api_base branch September 28, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants