No option for http_proxy #124

Closed
simonmorley opened this Issue Mar 1, 2014 · 4 comments

Comments

Projects
None yet
5 participants

We require an outbound proxy on our servers and have had to fork and temp. patch to facilitate.

Am I correct in assuming there's no option here for a proxy? If so, we'll test our patch some more and send a pull req.

-- EDIT --

Actually our fix didn't work. Initially, we inserted:

RestClient.proxy = "http://proxy.example.com/"

Into lib/stripe.rb to test. On dev. this worked but on Production we found it overrides all outbound requests, which we can't do.

@amfeng amfeng added feature labels Jul 8, 2014

gxbe commented Sep 22, 2014

I need this..

by the way.. with your patch.. you just set RestClient.proxy = nil again after the request has completed. I think this is thread safe

👍

Contributor

brandur commented Sep 29, 2015

Sorry for the delay in response on this one! Thanks for reporting.

As described in #219, I think it would be nice to upgrade some of the gem's HTTP infrastructure. I'll try to consider the requirement here as we patch that.

@brandur brandur added future and removed feature labels Oct 2, 2015

Contributor

brandur commented Oct 2, 2015

Created umbrella issue #313 and am closing this in favor of that.

@brandur brandur closed this Oct 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment