ACH Bank Account Verification

[zachflower]

Implements the functionality documented in the ACH Beta Guide: https://stripe.com/docs/guides/ach-beta

• BankAccount object added
• Verify ACH bank account method added
• Tests updated

[etipton]

+1 for this!

[matthewarkin]

As I've seen done in other repos, since this is a beta it won't get added to the libraries yet, since its a private beta they tend to not want links to the docs shared about, since its private and hence still subject to changes and stuff

[etipton]

@matthewarkin ah, that makes sense

[zachflower]

@matthewarkin that's a good point, I hadn't thought of that before submitting this.

[uri]

Is this a dup of #231?

[etipton]

Looks like it... except #231's code looks like it has incomplete testing and has commented-out lines of code...

[rodrigoargumedo]

This looks amazing. +1 for this.

[tonyhb]

Rebased here: https://github.com/tonyhb/stripe-ruby/tree/feature/verify-bank-account

[RichardGrossman]

Have you gotten a success response to bank_account.verify from Stripe? Their site shows a different format for amounts[].

[RichardGrossman]

The trick is to verify a bank account:

1
:headers => { 'Content-Type' => 'application/x-www-form-urlencoded', 'Accept' => 'application/json'}

Because the parameters Stripe wants are invalid as JSON.

And the Body like this

:body => "amounts[]=14&amounts[]=26",

[bkrausz]

Closing this PR, since it's redundant with #268, and we're likely to change this API in the near future to something more consistent with the notion of sources.

[RichardGrossman]

#bkrausz:

This hasn't been fixed yet so it shouldn't be closed.

I understand your comment "we're likely to change this API in the near future", but that hasn't happened yet. Do you think some coders may find the workaround valuable until then?

It's not redundant with #268 because #268 doesn't have a solution and I provided a work around above.

It would be best if this was reopened and kept open until there is another solution.

[bkrausz]

#268 is nearly identical to your PR: since your PR we've released a BankAccount object, and it adds a verify method to that object identical to yours.

We're hoping to have the new APIs released in the next week. I will keep #268 open until it's either merged or supplanted with new APIs.