Refactors code and other minor changes

[HashNuke]

Hi there

This is a re-submit of #27 with changes that were pointed out. (I've closed #27).

Changes:

• Refactors code into different files. So there's no more one huge stripe.rb
• Removes rest-client dependency specification from the stripe.rb file. It's already in the gemspec.
• Requires "stripe" in test_helper.rb instead of the relative path being used.
  Tests now have to be run with bundle exec rake test or equivalent in rbenv. Running without the bundle exec will fail.
• Adds a "Development" section to the README on how to run the test cases.

Fixes (as pointed out in #27)

• Rebases commits that aren't important to be in the history.
• Changes double quotes to single quotes.
  Refactors code into different files and other minor changes #27 (comment)
• Changes require path to stripe/version.
  Refactors code into different files and other minor changes #27 (comment)
• Fixes typo in commit message.
  Refactors code into different files and other minor changes #27 (comment)

P.S: In good faith and as a random response to a tweet - https://twitter.com/avdi/status/202091097906888704

[travisbot]

This pull request passes (merged 0c27b9c into 35e7375).

[gdb]

What did you think of my comment on this on the previous pull request (#27 (comment))?

[HashNuke]

Sorry, I forgot to reply to that.

gem() method is provided by Bundler. You can check that from your console itself. Try bundle exec irb, then do method(:gem).source_location. That'll give you the location of the definition.

As per my bundler version (1.1.rc), it's from line-122 of lib/bundler/rubygems_integration.rb

I also did a code search of rubygems/rubygems repo on Github to verify my facts https://github.com/search?q=repo%3Arubygems%2Frubygems+kernel&repo=&langOverride=&start_value=1&type=Code&language=

And it turned out that Rubygems doesn't provide a global gem() method. I checked that rest-client is at v1.6.x, since you are using 1.4 I assume it's because you want 1.8.7 compatibility. Why not just specify that in the gemspec? And also in the readme too. So then anyone who's using the gem from source and without Bundler, will find it easier to install specific versions of dependencies.

[HashNuke]

It seems like rubygems does provide a gem() method. irb and then method(:gem).source_location.

I would leave it upto you as to what to do now. Should I add that line back if , rebase the commits and send another pull request?

[gdb]

Yep, would add it back, and rebase. You don't actually need to do another pull request -- fine to just 'git push -f' this branch; the pull request will automatically update.

[gdb]

(Note that the reason we require ~> 1.4 is that pre-1.4 didn't support using your own CA file, or something along those lines. ~> 1.4 allows people to use any version above 1.4 but less than 2.0. We should probably add this to the README.)

[HashNuke]

Oh I didn't know about that.

---

Akash Manohar J
http://akash.im
@HashNuke

On Wednesday 23 May 2012 at 11:29 AM, Greg Brockman wrote:

require 'rubygems'

require 'openssl'

-gem 'rest-client', '~> 1.4'

(Note that the reason we require ~> 1.4 is that pre-1.4 didn't support using your own CA file, or something along those lines. ~> 1.4 allows people to use any version above 1.4 but less than 2.0. We should probably add this to the README.)

---

Reply to this email directly or view it on GitHub:
https://github.com/stripe/stripe-ruby/pull/28/files#r865777

[travisbot]

This pull request passes (merged bae485cd into 35e7375).

[travisbot]

This pull request passes (merged f21c271 into 35e7375).

[gdb]

Awesome, thanks much.

[HashNuke]

I'm still having a few doubts, won't the dependency be resolved while installing the gem itself, since the version limit is mentioned in the gemspec?

P.S: You can go ahead and merge it if you feel this is sufficient for now.

[gdb]

That should be the case, yes, for a normal install. However, we've
found that you need to be pretty defensive in client libraries, and
try to handle the cases where invariants end up being broken (because
that happens way more often than you'd like).

• gdb

On Tue, May 22, 2012 at 11:06 PM, Akash Manohar
reply@reply.github.com
wrote:

I'm still having a few doubts, won't the dependency be resolved while installing the gem itself, since the version limit is mentioned in the gemspec?

P.S: You can go ahead and merge it if you feel this if sufficient for now.

---

Reply to this email directly or view it on GitHub:
#28 (comment)