Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gem metadata #807

Merged
merged 1 commit into from Jul 4, 2019
Merged

Add gem metadata #807

merged 1 commit into from Jul 4, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

I wanted to test GitHub's new Package Registry feature and publish the latest stripe-ruby gem there. We need to add a custom github_repo entry to the metadata, because otherwise GitHub uses the gem's name as the repository's name, which in our case causes it to fail because the gem is called stripe and the repository is called stripe-ruby.

While I was at it, I also added standard metadata as documented on https://guides.rubygems.org/specification-reference/#metadata.

Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation in PR description! LGTM.

@stripe-ci stripe-ci assigned ob-stripe and unassigned brandur-stripe Jul 4, 2019
@ob-stripe ob-stripe merged commit 50748b1 into master Jul 4, 2019
@ob-stripe ob-stripe deleted the ob-gem-metadata branch July 4, 2019 22:47
@ob-stripe
Copy link
Contributor Author

Released as 4.21.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants