New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to dep for vendored dependency management #29

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
4 participants
@antifuchs
Copy link

antifuchs commented Jan 2, 2019

Summary

This PR switches unilog over to dep as a dependency manager.

Motivation

I couldn't run tests with the current state managed by govendor;
this works & brings unilog in line with veneur's vendor management
strategy.

Test plan

Ran tests locally.

Rollout/monitoring/revert plan

Just merge.

Switch to dep for vendor dependency management
This should bring unilog in line with most of our other OSS golang
projects.
@asf-stripe

This comment has been minimized.

Copy link
Contributor

asf-stripe commented Jan 2, 2019

@ChimeraCoder

This comment has been minimized.

Copy link
Collaborator

ChimeraCoder commented Jan 2, 2019

lurking in

lgtm

@asf-stripe asf-stripe merged commit 751fd6b into master Jan 2, 2019

3 checks passed

approval This PR has been approved by a reviewer.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@asf-stripe asf-stripe deleted the asf-dep branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment