Implement proxy connection support

[steve-todorov]

Task Description

We need to complete the proxy connection implementation. Currently we have:

1. Configuration endpoint which is capable of managing proxy connection configuration into strongbox.yaml
2. Configuration endpoint which is capable of managing storage repositories and also save their proxy connection configuration.
3. There is also UI for this.

However, the actual apache httpclient connection pool which is already in place is not honoring the saved configuration. The logic should be as follows:

1. Use the Global Proxy Configuration from strongbox.yaml when it's in place
2. If there is a Proxy Configuration for a Repository - it should take priority over the Global proxy
3. Hearbeat monitoring must also use the appropriate proxy configuration when checking if the repository is live (i.e. if repo has no proxy configuration, but global proxy configuration exists - it should use it; if there is no proxy configuration at all - use direct connection)

Task Relationships

This task:

• Relates to: Proxy repository for nuget does not actually use configured proxy #1663

Help

• Our chat
• Points of contact:
  • @carlspring
  • @fuss86
  • @sbespalov
  • @steve-todorov

[anki2189]

@carlspring @sbespalov : Why there are two implementation for http Client in ProxyRepositoryConnectionPoolConfigurationServiceImpl

• ProxyRepositoryConnectionPoolConfigurationServiceImpl#getRestClient()

• ProxyRepositoryConnectionPoolConfigurationServiceImpl#getHttpClient()

[sbespalov]

One is probably for REST and another for other HTTP interactions.

[carlspring]

I believe we should be using Apache's httpclient for everything. We shouldn't use the classes from the JDK for this.

I believe that ProxyRepositoryConnectionPoolConfigurationServiceImpl#getRestClient() should be renamed to ProxyRepositoryConnectionPoolConfigurationServiceImpl#getHttpClient() and the ProxyRepositoryConnectionPoolConfigurationServiceImpl#getRestClient() should be removed.

[sbespalov]

@carlspring they both using same poolingHttpClientConnectionManager. So we can say that Rest Client is just provide JAXRS interfaces above httpclient.

[carlspring]

Okay, thanks for the clarification!

[anki2189]

Below are the usages of ProxyRepositoryConnectionPoolConfigurationServiceImpl#getHttpClient()

• HttpGetRemoteRepositoryCheckStrategy#isAlive()

• RepositoryProxyIndexCreator#fetchIndex()

ProxyRepositoryConnectionPoolConfigurationServiceImpl#getRestClient()

• NugetRepositoryFeatures#downloadRemoteFeed()

• NugetRepositoryFeatures.RepositorySearchEventListener#handle()

• NpmRepositoryFeatures#fetchRemoteChangesFeed()

• NpmRepositoryFeatures#fetchRemotePackageFeed()

• NpmRepositoryFeatures#fetchRemoteSearchResult()

• RestArtifactResolverFactory#newInstance()

• FetchChangesFeedCronJobTestIT#prepareArtifactResolverContext()

• ArtifactResolverIT#setUp()

• ProxyRepositoryConnectionPoolConfigurationServiceImplIT#connectionsLeakedTest()

• ProxyRepositoryConnectionPoolConfigurationServiceImplIT#connectionsReleasedTest()

[steve-todorov]

@anki2189 ping - have you had a chance to look into this yet? :)

[anki2189]

@steve-todorov : Yes, I am working on it , didn't get the time to test the flow.

[steve-todorov]

Okay, thanks for the update! :)

[carlspring]

@anki2189 ,

What is the status of this task?