Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Unit tests failure: req .signedCookies should return a signed cookie #1538

Closed
fern4lvarez opened this Issue · 7 comments

5 participants

@fern4lvarez

I found this error running unit tests. Just to make sure, I cloned the repo again, installed dependencies and ran tests again. So reproducing the failure is straight-forward for me:

# On Ubuntu 12.04, running node v.0.8.22
$ git clone git@github.com:visionmedia/express.git
$ cd express
$ sudo su
# npm install
# make test
...
✖ 1 of 377 tests failed:

1) req .signedCookies should return a signed cookie:
   Error: expected '{"foo":"bar"}' response body, got '{"obj":{"foo":"bar"},"foo":"bar"}'
    at Test.assert (/home/fa/github/express/node_modules/supertest/lib/test.js:140:17)
    at Test.end (/home/fa/github/express/node_modules/supertest/lib/test.js:102:10)
    at Test.<anonymous> (/home/fa/github/express/node_modules/supertest/node_modules/superagent/lib/node/index.js:124:10)
    at Test.EventEmitter.emit (events.js:88:17)
    at IncomingMessage.Request.end (/home/fa/github/express/node_modules/supertest/node_modules/superagent/lib/node/index.js:565:12)
    at IncomingMessage.EventEmitter.emit (events.js:115:20)
    at IncomingMessage._emitEnd (http.js:366:10)
    at HTTPParser.parserOnMessageComplete [as onMessageComplete] (http.js:149:23)
    at Socket.socketOnData (http.js:1366:20)
    at TCP.onread (net.js:402:27)

Something wrong with my local set-up?

@slaskis

Travis seems to get the same results so I don't think it's your set-up.

Strangely enough Travis seems to fail on node 0.6 instead of 0.8.

@tj
tj commented

hmm they all pass for me

@jonathanong

still seeing this, but it happens sporadically on travis.

@chirag04

@jonathanong @visionmedia

Seems like test fail on node 0.10+ but passes on 0.8+

@jonathanong

@chirag04 different test

@chirag04

Issues is already raised for the failing test i was talking about on node 0.10+
#1758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.