Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arguments for 2 commands #410

Merged
merged 1 commit into from Jun 20, 2019

Conversation

Projects
None yet
2 participants
@jannyHou
Copy link
Contributor

commented Jun 19, 2019

Description

Similar to #408
Honor the arguments in the remote method and middleware commands.

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide
@jannyHou

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

The failure from loopback-cli is not relevant

22:38:31 > loopback-cli@5.0.2 test /home/jenkins/workspace/ds/loopback-cli~master
22:38:31 > mocha
22:38:31 
22:38:31 /home/jenkins/workspace/ds/loopback-cli~master/node_modules/strong-globalize/node_modules/os-locale/index.js:27
22:38:31 async function getLocales() {
22:38:31       ^^^^^^^^

@jannyHou jannyHou merged commit 8ba8462 into master Jun 20, 2019

13 of 15 checks passed

[cis-jenkins] PR Builder Build finished.
Details
[cis-jenkins] downstream: loopback-cli@master Failed! (3b6c9c9)
Details
Commit Linter commits are all properly formatted
Details
PR Linter PR is up to date
Details
[cis-jenkins] downstream: apiconnect-cli-loopback@master Success! (3b6c9c9)
Details
[cis-jenkins] x64 && linux && nvm,10 Success! (3b6c9c9)
Details
[cis-jenkins] x64 && linux && nvm,8 Success! (3b6c9c9)
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
generator-loopback Success! (3b6c9c9)
Details
generator-loopback/node=4.x,os=windows Success! (3b6c9c9)
Details
generator-loopback/node=6.x,os=windows Success! (3b6c9c9)
Details
pr-builder
Details
security/snyk - package.json (StrongLoop) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix/argument branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.