Upgrade to strong-swagger-ui@21.0 (swagger-ui@2.1) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slnode test please |
| @@ -16,12 +21,27 @@ $(function() { | |||
| apiKey: '', | |||
| dom_id: 'swagger-ui-container', | |||
| supportHeaderParams: true, | |||
| supportedSubmitMethods: ['get', 'post', 'put', 'delete'], | |||
| supportedSubmitMethods: ['get', 'post', 'put', 'delete', 'patch'], | |||
There was a problem hiding this comment.
AFAICT, the flag "supportedSubmitMethods" controls whether operation's model is editable or readonly.
By default, this array is set to all HTTP verbs:
To be honest, I don't completely understand the purpose of this option. I just applied the value from swagger-ui's index.html. Perhaps we can remove this line completely and use swagger-ui's default instead?
|
I have removed @raymondfeng LGTY now? |
|
LGTM |
bajtos
force-pushed
the
feature/upgrade-to-swagger-ui-2.1
branch
from
2d76f3c
to
30017c8
Compare
|
@slnode test please |
bajtos
added a commit
that referenced
this pull request
Aug 13, 2015
…-2.1 Upgrade to strong-swagger-ui@21.0 (swagger-ui@2.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch upgrades loopback-explorer to use strong-swagger-ui@21.0, which is based on swagger-ui@2.1 and supports Swagger Spec 2.0.
Notes
GET /models, the response model is not correctly rendered ATM. I suspect this is caused by Pick up enhancement from shelbys #111 and/or Pick up enhancements from shelbys master #113, I'll be investigating the problem after this PR is landed.Connect to strongloop-internal/scrum-loopback#412
Connect to #54
/to @raymondfeng @STRML please review