Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
#267 get all groups for ms-ad #272
groupSearch results were based on the _groups ldap attribute and ignored the memberOf attribute which is traditionally used in Active Directory. This fix makes sure both work.
referenced this pull request
May 24, 2019
jannyHou left a comment
@Tyler-RCSD Thank you for the contribution.
If it's a field only used in your project, then the fix should be "honor custom ldapAttrName", you can specify it in the configuration file, then use
And can you also add a test case?
Let me know if you have other questions and I can help you land the PR.
memberOf is the standard attribute within Microsoft Active Directory for groups. I think anyone would expect that this should work out of the box with AD without having to configure a custom ldapAttrName for groups.
I will see if I can figure out a test case next week. Honestly, I'm not all that familiar with writing test cases so if someone has a suggestion please let me know.