Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI failures #81

Merged
merged 1 commit into from Jul 17, 2019

Conversation

@emonddr
Copy link
Contributor

commented Jul 17, 2019

Description

Fix CI failures

Related issues

connect to #76

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@emonddr emonddr self-assigned this Jul 17, 2019

@emonddr emonddr removed the request for review from virkt25 Jul 17, 2019

@emonddr

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

This commit fixes a lint problem.

The real fix was to

  1. create a new VM for dashdb (the previous one stopped working).

  2. Set DDL_CONSTRAINT_DEF = YES in the database itself to have unique constraints enforced
    (dashdb (db2 warehouse) is different than plain db2 in that it no longer enforces unique id
    constraints out of the box...the user must turn it on).

  3. @rmg made changes to Jenkins environment variables as per our request.

For complete details of the investigation to fix this problem, please see #76.

@emonddr emonddr requested review from nabdelgadir and agnes512 and removed request for dhmlau Jul 17, 2019

@dhmlau

dhmlau approved these changes Jul 17, 2019

@emonddr emonddr merged commit be44ffa into master Jul 17, 2019

8 checks passed

Commit Linter commits are all properly formatted
Details
PR Linter PR is up to date
Details
[cis-jenkins] PR Builder Build finished.
Details
[cis-jenkins] x64 && linux && nvm,10 Success! (9aa7ec4)
Details
[cis-jenkins] x64 && linux && nvm,6 Success! (9aa7ec4)
Details
[cis-jenkins] x64 && linux && nvm,8 Success! (9aa7ec4)
Details
clahub All contributors have signed the Contributor License Agreement.
Details
security/snyk - package.json (StrongLoop) No new issues
Details

@delete-merged-branch delete-merged-branch bot deleted the dremond_fix_ci_failures branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.