Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linting issues #135

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@emonddr
Copy link
Contributor

commented Jul 10, 2019

Description

Fix linting issues

Related issues

connect to #130

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide
@emonddr

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@b-admike and I looked into the failures.

The vm in fyre.ibm.com that is typically used for these CI tests was down (not accepting sign-in via ssh, had many security patches waiting for installation, and shutting down and restarting wasn't working).

We had to create a new VM with db2 and got npm test running successfully from our laptop.

We contacted @rmg , and he updated our environment variables in Jenkins to point to our new machine.

The only remaining issues were lint problems.

This commit fixes the lint problems.

@emonddr emonddr removed request for virkt25 and dhmlau Jul 10, 2019

@b-admike
Copy link
Member

left a comment

👍

@dhmlau

dhmlau approved these changes Jul 10, 2019

@emonddr emonddr merged commit 9c20765 into master Jul 11, 2019

8 checks passed

Commit Linter commits are all properly formatted
Details
PR Linter PR is up to date
Details
[cis-jenkins] PR Builder Build finished.
Details
[cis-jenkins] x64 && linux && nvm,10 Success! (2dda480)
Details
[cis-jenkins] x64 && linux && nvm,6 Success! (2dda480)
Details
[cis-jenkins] x64 && linux && nvm,8 Success! (2dda480)
Details
clahub All contributors have signed the Contributor License Agreement.
Details
security/snyk - package.json (StrongLoop) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the dremond_fix_linting_issues branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.