Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix/nested decimal props #501
Fixes #493; Coerce decimal property values from string to decimal128 at every level of the model definition tree. The decimal properties can be nested in an Array, Object, and any combination of those. Depends on strongloop/loopback-datasource-juggler#1702 for model with property
referenced this pull request
Apr 2, 2019
For the last commit, I used https://github.com/strongloop/loopback-connector-mongodb/pull/483/files#diff-f44d7a6206dcaa5ddd05b31118b5c2be as inspiration to fix one of the failing tests on master.
bajtos left a comment
Almost there! Please make sure all new promise-based tests are returning a promise to Mocha (see one of the comments below).
Other comments are minor and can be ignored. No further review is necessary as far as I am concerned.
It would be great if you could get one more person to approve the changes, e.g. @jannyHou.
The test failures below are what #505 aims to fix and are not introduced by this PR (also fail on master):
Therefore, I'm going to merge this PR and hopefully we can fix them in #505.