Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make local tests pass #190

Open
hacksparrow opened this issue Sep 18, 2019 · 0 comments

Comments

@hacksparrow
Copy link
Member

hacksparrow commented Sep 18, 2019

Currently running source setup.sh and then npm test will result in the command left hanging.

It is caused by sath89/oracle-xe-11g being gone from Docker Hub. A good replacement is webdizz/oracle-xe-11g-sa.

Some things I noted while working on #183:

  1. Replace sath89/oracle-xe-11g with webdizz/oracle-xe-11g-sa or something similar.
  2. Hard-coded values in tests makes the use of custom username (schema) impossible. Remote and local usernames have to be the same or hard-coded values have to be replaced with configurable ones.
  3. The code in test/tables.sql has to be edited to make it work with the latest version of sqlplus, the client used by the local test setup.
  4. Use of UTC offset in the dateToOracle function was making tests fail on my machine. It looked like a timezone thing.
@hacksparrow hacksparrow referenced this issue Sep 18, 2019
0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.