Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run shared tests from both v3 and v4 of juggler #180

Merged
merged 1 commit into from Jul 17, 2019

Conversation

@nabdelgadir
Copy link
Contributor

commented Jul 15, 2019

Description

Run shared tests from juggler v3 and v4.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

@nabdelgadir nabdelgadir self-assigned this Jul 15, 2019

@nabdelgadir nabdelgadir force-pushed the build/test-juggler-v3-and-v4 branch 9 times, most recently from 5f6afca to b4c23f8 Jul 15, 2019

@nabdelgadir nabdelgadir marked this pull request as ready for review Jul 16, 2019

@nabdelgadir

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

CI failure isn't related, but it's tracked in #183.

@b-admike
Copy link
Member

left a comment

One comment, otherwise LGTM.

@@ -15,7 +15,7 @@
"main": "index.js",
"scripts": {
"lint": "eslint .",
"test": "mocha --UV_THREADPOOL_SIZE=100 --require test/init/init.js test/*.js",
"test": "mocha test/*.test.js node_modules/juggler-v3/test.js node_modules/juggler-v4/test.js",

This comment has been minimized.

Copy link
@b-admike

b-admike Jul 16, 2019

Member

do we not need the UV_THREADPOOL_SIZE flag anymore?

This comment has been minimized.

Copy link
@nabdelgadir

nabdelgadir Jul 17, 2019

Author Contributor

Let me add it back; I removed it by accident. Thanks!

@nabdelgadir nabdelgadir force-pushed the build/test-juggler-v3-and-v4 branch from b4c23f8 to 88e91e4 Jul 17, 2019

@nabdelgadir nabdelgadir merged commit 65453db into master Jul 17, 2019

8 of 11 checks passed

[cis-jenkins] PR Builder Build finished.
Details
[cis-jenkins] x64 && linux && nvm,10 Failed! (88e91e4)
Details
[cis-jenkins] x64 && linux && nvm,8 Failed! (88e91e4)
Details
Commit Linter commits are all properly formatted
Details
PR Linter PR is up to date
Details
clahub All contributors have signed the Contributor License Agreement.
Details
loopback-connector-oracle Success! (88e91e4)
Details
loopback-connector-oracle/node=4.x,os=windows Success! (88e91e4)
Details
loopback-connector-oracle/node=6.x,os=windows Success! (88e91e4)
Details
pr-builder
Details
security/snyk - package.json (StrongLoop) No new issues
Details

@delete-merged-branch delete-merged-branch bot deleted the build/test-juggler-v3-and-v4 branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.