Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update oracledb to v4 #186

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@nabdelgadir
Copy link
Contributor

commented Jul 26, 2019

Description

update oracledb to v4

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
@nabdelgadir

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

New failure (for all node versions):

1) lazyConnect
        should report connection error (lazyConnect = false):
      Uncaught AssertionError: expected 'ORA-24415: Missing or null username.' to contain 'TNS'

Other CI failures are tracked in #183

@nabdelgadir nabdelgadir force-pushed the update-oracle-v4 branch from 49ca72b to 4c0e1d9 Jul 29, 2019

@nabdelgadir nabdelgadir self-assigned this Jul 29, 2019

@nabdelgadir nabdelgadir force-pushed the update-oracle-v4 branch from 4c0e1d9 to db66cbb Jul 29, 2019

@nabdelgadir nabdelgadir marked this pull request as ready for review Jul 29, 2019

@nabdelgadir

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

The lazyConnect failure was fixed with this line but the rest of the CI failures aren't related to this PR and are already tracked in #183.

@emonddr emonddr self-requested a review Jul 29, 2019

@emonddr
Copy link

left a comment

Looks good :)

@agnes512
Copy link

left a comment

The lazyConnect failure was fixed with this line but the rest of the CI failures aren't related to this PR and are already tracked in #183.

Oh it makes sense now. I was wondering if updated to v4 causes new failure

@nabdelgadir nabdelgadir merged commit ce8442c into master Jul 29, 2019

8 of 12 checks passed

[cis-jenkins] PR Builder Build finished.
Details
[cis-jenkins] x64 && linux && nvm,10 Failed! (db66cbb)
Details
[cis-jenkins] x64 && linux && nvm,12 Failed! (db66cbb)
Details
[cis-jenkins] x64 && linux && nvm,8 Failed! (db66cbb)
Details
Commit Linter commits are all properly formatted
Details
PR Linter PR is up to date
Details
clahub All contributors have signed the Contributor License Agreement.
Details
loopback-connector-oracle Success! (db66cbb)
Details
loopback-connector-oracle/node=4.x,os=windows Success! (db66cbb)
Details
loopback-connector-oracle/node=6.x,os=windows Success! (db66cbb)
Details
pr-builder
Details
security/snyk - package.json (StrongLoop) No new issues
Details

@delete-merged-branch delete-merged-branch bot deleted the update-oracle-v4 branch Jul 29, 2019

@dhmlau dhmlau referenced this pull request Jul 29, 2019
5 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.