Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only callback after the connection is released #193

Merged
merged 2 commits into from Nov 1, 2019

Conversation

@raymondfeng
Copy link
Member

raymondfeng commented Nov 1, 2019

Fixes strongloop/loopback-next#3296

Description

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide
@raymondfeng raymondfeng requested review from b-admike, dhmlau and jannyHou as code owners Nov 1, 2019
@raymondfeng raymondfeng force-pushed the fix-loopback-next-3296 branch from e7093b1 to 535392b Nov 1, 2019
@bajtos
bajtos approved these changes Nov 1, 2019
Copy link
Member

bajtos left a comment

I am not able to fully asses the impact of these changes, but don't see any major problem.

example/app.js Show resolved Hide resolved
@hacksparrow

This comment has been minimized.

Copy link
Member

hacksparrow commented Nov 1, 2019

@raymondfeng what about the accompanying tests?

@dhmlau
dhmlau approved these changes Nov 1, 2019
@dhmlau
dhmlau approved these changes Nov 1, 2019
Copy link
Contributor

dhmlau left a comment

I'm not familiar with the code but the changes look reasonable to me. Thanks.

Copy link
Contributor

jannyHou left a comment

LGTM

@emonddr
emonddr approved these changes Nov 1, 2019
Copy link

emonddr left a comment

Please add a test case. thx.

@raymondfeng raymondfeng force-pushed the fix-loopback-next-3296 branch from 4e308d5 to 4223d35 Nov 1, 2019
@raymondfeng raymondfeng merged commit 8e9a17c into master Nov 1, 2019
12 checks passed
12 checks passed
Commit Linter commits are all properly formatted
Details
PR Linter PR is up to date
Details
[cis-jenkins] PR Builder Build finished.
Details
[cis-jenkins] x64 && linux && nvm,10 Success! (4223d35)
Details
[cis-jenkins] x64 && linux && nvm,12 Success! (4223d35)
Details
[cis-jenkins] x64 && linux && nvm,8 Success! (4223d35)
Details
clahub All contributors have signed the Contributor License Agreement.
Details
loopback-connector-oracle Success! (4223d35)
Details
loopback-connector-oracle/node=4.x,os=windows Success! (4223d35)
Details
loopback-connector-oracle/node=6.x,os=windows Success! (4223d35)
Details
pr-builder
Details
security/snyk - package.json (StrongLoop) No manifest changes detected
@delete-merged-branch delete-merged-branch bot deleted the fix-loopback-next-3296 branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.