Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent adding listeners past limit #149

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@emonddr
Copy link
Contributor

commented Aug 1, 2019

Description

Prevent adding listeners to 'connected' event past the limit established in the
datasource.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

@emonddr emonddr requested review from b-admike, dhmlau and jannyHou as code owners Aug 1, 2019

@emonddr emonddr force-pushed the dremond_migrate_errors branch from ca2d52e to e3f21d6 Aug 1, 2019

@nabdelgadir nabdelgadir force-pushed the dremond_migrate_errors branch 4 times, most recently from 0faedcf to a569958 Aug 2, 2019

@nabdelgadir

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

strongloop/loopback-datasource-juggler#1767 needs to be landed first to fix the non-downstream CI issues.

@nabdelgadir nabdelgadir self-assigned this Aug 2, 2019

.eslintrc Outdated Show resolved Hide resolved
@dhmlau
dhmlau approved these changes Aug 8, 2019
Copy link
Contributor

left a comment

I'm not familiar with this repo but your changes look reasonable to me.
I have one question about the ignoreStrings.

Please make sure you get at least one more reviews before landing. Thanks.

@nabdelgadir

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

@slnode test please

@nabdelgadir nabdelgadir force-pushed the dremond_migrate_errors branch from c534386 to 6babcd7 Aug 12, 2019

@jannyHou

This comment has been minimized.

Copy link

commented Aug 12, 2019

@slnode test please

@nabdelgadir nabdelgadir removed the request for review from b-admike Aug 12, 2019

@@ -459,4 +459,22 @@ describe('sql connector', function() {
done(err, results);
});
});

it('should throw if the event listener limit is reached', function() {

This comment has been minimized.

Copy link
@emonddr

emonddr Aug 13, 2019

Author Contributor

@nabdelgadir we should also have a test when limit is not reached.

This comment has been minimized.

Copy link
@nabdelgadir

nabdelgadir Aug 13, 2019

Contributor

added

@nabdelgadir nabdelgadir force-pushed the dremond_migrate_errors branch from 6babcd7 to 1ad8fa5 Aug 13, 2019

fix: prevent adding listeners past limit
Co-authored-by: Dominique Emond <dremond@ca.ibm.com>

@nabdelgadir nabdelgadir force-pushed the dremond_migrate_errors branch from 1ad8fa5 to 7ab10fb Aug 13, 2019

@nabdelgadir nabdelgadir merged commit 819bf8b into master Aug 14, 2019

32 of 36 checks passed

[cis-jenkins] PR Builder Build finished.
Details
[cis-jenkins] downstream: loopback-connector-ibmi@master Failed! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-kv-extreme-scale@master Failed! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-oracle@master Failed! (7ab10fb)
Details
Commit Linter commits are all properly formatted
Details
PR Linter PR is up to date
Details
[cis-jenkins] downstream: lb-con-test-app@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-cassandra@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-cloudant@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-couchdb2@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-dashdb@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-db2@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-db2iseries@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-db2z@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-informix@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-kv-redis@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-mongodb@3.x Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-mongodb@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-mssql@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-mysql@4.x Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-mysql@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-connector-postgresql@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-datasource-juggler@3.x Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-datasource-juggler@master Success! (7ab10fb)
Details
[cis-jenkins] downstream: loopback-ibmdb@master Success! (7ab10fb)
Details
[cis-jenkins] x64 && linux && nvm,10 Success! (7ab10fb)
Details
[cis-jenkins] x64 && linux && nvm,12 Success! (7ab10fb)
Details
[cis-jenkins] x64 && linux && nvm,8 Success! (7ab10fb)
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
loopback-connector Success! (7ab10fb)
Details
loopback-connector/node=4.x,os=windows Success! (7ab10fb)
Details
loopback-connector/node=6.x,os=windows Success! (7ab10fb)
Details
pr-builder
Details
security/snyk - package.json (StrongLoop) No new issues
Details

@delete-merged-branch delete-merged-branch bot deleted the dremond_migrate_errors branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.