Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: nested property coercion and resolution #1702
Ensure that nested array properties maintain connector-specific data type metadata and also coerce string values for array of primitive properties into their type. Connect to strongloop/loopback-connector-mongodb#493.
I am not able to fully asses possible impacts of this change in a wider context. Having said that, your proposal looks reasonable to me.
I am not sure if we want to fix support for data structures with even deeper nesting than you have in our examples, PTAL at my comments below.
I am ok to leave such edge cases out of scope of this pull request if you prefer. I think your patch is a good improvement that's worth landing even if it does not fix everything.
This was referenced
Apr 2, 2019
referenced this pull request
Apr 12, 2019
jannyHou left a comment
@b-admike Great effort on the coercion fix!
I read though your chat with the customer in strongloop/loopback-connector-mongodb#493, just a clue: maybe your change is not picked up because both
And the PR seems fixes the coercion for