Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node.js 12.x [3.x] #1729

Merged
merged 1 commit into from May 2, 2019

Conversation

@bajtos
Copy link
Member

commented Apr 30, 2019

Back-port #1728:

  • Fix code to pass all tests on Node.js 12
  • Add Node.js 12 to the list of Travis CI platforms
Add support for Node.js 12.x
- Fix code to pass all tests on Node.js 12
- Add Node.js 12 to the list of Travis CI platforms

@bajtos bajtos changed the base branch from master to 3.x Apr 30, 2019

@bajtos bajtos changed the title Chore/add node 12 3x Add support for Node.js 12.x Apr 30, 2019

@bajtos bajtos self-assigned this Apr 30, 2019

@bajtos bajtos requested a review from raymondfeng Apr 30, 2019

@bajtos bajtos changed the title Add support for Node.js 12.x Add support for Node.js 12.x [2.x] Apr 30, 2019

@dhmlau

dhmlau approved these changes Apr 30, 2019

@hacksparrow hacksparrow self-requested a review May 2, 2019

@hacksparrow
Copy link
Member

left a comment

👏

@bajtos bajtos changed the title Add support for Node.js 12.x [2.x] Add support for Node.js 12.x [3.x] May 2, 2019

@bajtos bajtos merged commit e27efd9 into 3.x May 2, 2019

28 of 35 checks passed

[cis-jenkins] PR Builder Build finished.
Details
[cis-jenkins] downstream: loopback-connector-dashdb@master Failed! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-db2@master Failed! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-mongodb@3.x Failed! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-oracle@master Failed! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-rest@master Failed! (70b3d21)
Details
[cis-jenkins] downstream: loopback-ibmdb@master Failed! (70b3d21)
Details
Commit Linter commits are all properly formatted
Details
PR Linter PR is up to date
Details
[cis-jenkins] downstream: angular-live-set@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-cassandra@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-cloudant@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-couchdb2@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-grpc@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-kv-redis@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-mongodb@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-mssql@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-mysql@4.x Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-mysql@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-postgresql@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector-remote@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-connector@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback-sdk-angular@master Success! (70b3d21)
Details
[cis-jenkins] downstream: loopback@master Success! (70b3d21)
Details
[cis-jenkins] x64 && linux && nvm,10 Success! (70b3d21)
Details
[cis-jenkins] x64 && linux && nvm,6 Success! (70b3d21)
Details
[cis-jenkins] x64 && linux && nvm,8 Success! (70b3d21)
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on chore/add-node-12-3x at 83.937%
Details
loopback-datasource-juggler Success! (70b3d21)
Details
loopback-datasource-juggler/node=4.x,os=windows Success! (70b3d21)
Details
loopback-datasource-juggler/node=6.x,os=windows Success! (70b3d21)
Details
pr-builder
Details
security/snyk - package.json (StrongLoop) No new issues
Details

@bajtos bajtos deleted the chore/add-node-12-3x branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.