Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the authentication action to be a common one. #2467

Closed
jannyHou opened this issue Feb 25, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@jannyHou
Copy link
Contributor

commented Feb 25, 2019

Description

Refactor the authentication action to be a common one that could perform authenticate for both non-passport based strategies and passport based strategies.

Acceptance criteria

  • Refactor action so that it could perform any strategy's authenticate method, not only passport based ones.
    • The returned strategy should be described using the AuthenticationStrategy interface created in #2466
@bajtos

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

Isn't this a necessary part of #2466: Add abstraction for authentication strategy? I mean what is a new abstraction good for, when it's not used by the authentication action?

@jannyHou

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

I was trying to split the abstraction story into separate ones, honestly without working on the code I couldn't say for sure does the auth action have to be refactored together with the auth strategy interface 😞

@emonddr

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

May involve the work needed in #2311

@dhmlau dhmlau added this to the May 2019 milestone milestone Apr 29, 2019

@dhmlau dhmlau referenced this issue Apr 30, 2019

Closed

Monthly Milestone - May 2019 🌷🐝 🍄 #2818

27 of 32 tasks complete

@jannyHou jannyHou referenced this issue May 7, 2019

Closed

Draft/passport strategy #2822

1 of 7 tasks complete

@jannyHou jannyHou self-assigned this May 7, 2019

@dhmlau

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@emonddr @jannyHou, now that PR #2688 has landed, is this task done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.