Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change `Principal` to be `TypedPrincipal` in the authorize interceptor #3845

Closed
jannyHou opened this issue Sep 30, 2019 · 1 comment

Comments

@jannyHou
Copy link
Contributor

jannyHou commented Sep 30, 2019

Steps to reproduce

The authorizeInterceptor should use TypedPrincipal instead of Principal in the
authorization context.
And we should provide a default factory that converts a
user profile to a typed principal in @loopback/security.
See PR #3807

Current Behavior

Authorizer interceptor still uses a more general type Principal, see code and code

Expected Behavior

User TypedPrincipal instead.

Acceptance Criteria

  • Refactor Principal to be TypedPrincipal in the authorize interceptor.
@jannyHou

This comment has been minimized.

Copy link
Contributor Author

jannyHou commented Oct 4, 2019

When I worked on #3807 I thought creating an instance of TypedPrincipal would be easier than having the converter. Just tried to change the Principal to TypedPrincipal on local and found it's not very reasonable, since it regenerate the securityId with type name as prefix, which is not a necessary in the current design.

I am closing this issue, we can reopen it when new features that needs this change get added to authorization.

@jannyHou jannyHou closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.