Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifeCycleObserver is not working with express composition #3878

Closed
JamilOmar opened this issue Oct 4, 2019 · 6 comments · Fixed by #3879
Assignees
Labels
bug

Comments

@JamilOmar
Copy link

@JamilOmar JamilOmar commented Oct 4, 2019

  1. Have an lb4 app with a lifeCycleObserver.
  2. Convert this app into an express app using express composition.
  3. The lifeCycleObserver does not run.

Current Behavior

Is not running after converted into an express app.

Expected Behavior

lifeCycleObserver running.

Link to reproduction sandbox

Additional information

Related Issues

See Reporting Issues for more tips on writing good issues

@JamilOmar JamilOmar added the bug label Oct 4, 2019
@raymondfeng

This comment has been minimized.

Copy link
Member

@raymondfeng raymondfeng commented Oct 4, 2019

You need to call the following:

await lb4app.boot();
await lb4app.start()
@JamilOmar

This comment has been minimized.

Copy link
Author

@JamilOmar JamilOmar commented Oct 4, 2019

if you have multiple express apps , you will receive an exception because the port is already in use

@raymondfeng

This comment has been minimized.

Copy link
Member

@raymondfeng raymondfeng commented Oct 4, 2019

Yes. I’m working on a fix to disable Http listening for lb4 app.

@JamilOmar

This comment has been minimized.

Copy link
Author

@JamilOmar JamilOmar commented Oct 4, 2019

Do you have an approximate time for that release?

@raymondfeng

This comment has been minimized.

Copy link
Member

@raymondfeng raymondfeng commented Oct 4, 2019

The quick workaround is to have lb4 app listening a different port with host 127.0.0.1.

@dhmlau

This comment has been minimized.

Copy link
Contributor

@dhmlau dhmlau commented Oct 7, 2019

PR #3879 is in progress.

raymondfeng added a commit that referenced this issue Oct 7, 2019
raymondfeng added a commit that referenced this issue Oct 7, 2019
raymondfeng added a commit that referenced this issue Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.