New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update steps to deploy to IBM Cloud #2039

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
3 participants
@dhmlau
Contributor

dhmlau commented Nov 16, 2018

Originated from #2033

In this PR,

  • fix the code snippet in index.ts to get it working
  • add the instruction to sign up for IBM Cloud and include information on creating a Cloudant service.

Will submit another PR for some more improvements, but would like to get this PR up first so that users won't get stuck on the outdated instruction.

@dhmlau dhmlau requested review from bajtos and raymondfeng as code owners Nov 16, 2018

@b-admike

One concern, otherwise LGTM 👍

Show resolved Hide resolved docs/site/Deploying-to-IBM-Cloud.md Outdated

@dhmlau dhmlau force-pushed the bluemix branch from 181979e to 9033028 Nov 16, 2018

@dhmlau dhmlau merged commit ece2f7d into master Nov 16, 2018

5 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.022%
Details
security/snyk - package.json (dhmlau) No manifest changes detected

@dhmlau dhmlau deleted the bluemix branch Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment