Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat(context): binding filters #2289
Conversation
bajtos
added
feature
IoC/Context
labels
Jan 25, 2019
bajtos
added this to the January 2019 milestone milestone
Jan 25, 2019
bajtos
self-assigned this
Jan 25, 2019
bajtos
requested review from
raymondfeng
,
hacksparrow
and
jannyHou
Jan 25, 2019
bajtos
referenced this pull request
Jan 25, 2019
Open
feat(context): add support to watch context bindings #2122
hacksparrow
approved these changes
Jan 25, 2019
This comment has been minimized.
This comment has been minimized.
|
LGTM. |
raymondfeng
approved these changes
Jan 25, 2019
bajtos
merged commit ff85e74
into
master
Jan 25, 2019
6 checks passed
clahub
All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/branch
AppVeyor build succeeded
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
coverage/coveralls
Coverage increased (+0.006%) to 90.725%
Details
security/snyk - package.json (dhmlau)
No new issues
Details
bajtos
deleted the
feat/binding-filters
branch
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bajtos commentedJan 25, 2019
I have extracted this patch from #2122 to get it landed faster. I noticed that #2122 was not including any tests for the new APIs, so I added few basic test cases to make sure future contributors have a place where to add new tests.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated