New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(context): binding filters #2289

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
3 participants
@bajtos
Copy link
Member

bajtos commented Jan 25, 2019

I have extracted this patch from #2122 to get it landed faster. I noticed that #2122 was not including any tests for the new APIs, so I added few basic test cases to make sure future contributors have a place where to add new tests.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated
feat(context): binding filters
Co-Authored-By: Raymond Feng <raymondfeng@users.noreply.github.com>

@bajtos bajtos added this to the January 2019 milestone milestone Jan 25, 2019

@bajtos bajtos self-assigned this Jan 25, 2019

@bajtos bajtos requested review from raymondfeng , hacksparrow and jannyHou Jan 25, 2019

@bajtos bajtos referenced this pull request Jan 25, 2019

Open

feat(context): add support to watch context bindings #2122

5 of 7 tasks complete
@hacksparrow

This comment has been minimized.

Copy link
Member

hacksparrow commented Jan 25, 2019

LGTM.

@bajtos bajtos merged commit ff85e74 into master Jan 25, 2019

6 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 90.725%
Details
security/snyk - package.json (dhmlau) No new issues
Details

@bajtos bajtos deleted the feat/binding-filters branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment