Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): introduce requestBodyParser options in RestServerOptions #2432

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
3 participants
@raymondfeng
Copy link
Member

raymondfeng commented Feb 20, 2019

Inspired by #2415.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated
  • Agree to the CLA (Contributor License Agreement) by clicking and signing

@raymondfeng raymondfeng requested a review from bajtos as a code owner Feb 20, 2019

@b-admike
Copy link
Member

b-admike left a comment

Awesome 💯

});
app.component(RestComponent);
const server = await app.getServer(RestServer);
expect(server.getSync(RestBindings.REQUEST_BODY_PARSER_OPTIONS)).to.equal(

This comment has been minimized.

@b-admike

b-admike Feb 20, 2019

Member

nitpick: can we use get here instead of getSync with await to keep it in sync with the async/await style of the test?

This comment has been minimized.

@raymondfeng

raymondfeng Feb 20, 2019

Author Member

I wanted to assert that the options can be resolved synchronously.

@raymondfeng raymondfeng merged commit c7f59ba into master Feb 20, 2019

5 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 90.463%
Details

@raymondfeng raymondfeng deleted the expose-request-body-parser-options branch Feb 20, 2019

@bajtos
Copy link
Member

bajtos left a comment

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.