Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openapi-v3): add operationId based on controller/method names #2533

Merged
merged 2 commits into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@raymondfeng
Copy link
Member

raymondfeng commented Mar 4, 2019

While was working on strongloop/loopback-connector-swagger#52, I realized that LB4 does not generate operationId for OpenAPI operation specs.

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@raymondfeng raymondfeng requested a review from bajtos as a code owner Mar 4, 2019

@raymondfeng raymondfeng force-pushed the add-operation-id branch from 7477377 to aa5a964 Mar 4, 2019

@jannyHou
Copy link
Contributor

jannyHou left a comment

I left a nitpick for adding the operationId in the openapi-spec-builder module and update tests accordingly. Otherwise LGTM 馃憤

@raymondfeng raymondfeng force-pushed the add-operation-id branch from aa5a964 to 008d211 Mar 4, 2019

@raymondfeng raymondfeng force-pushed the add-operation-id branch 3 times, most recently from 780ee8a to 2739977 Mar 5, 2019

@raymondfeng

This comment has been minimized.

Copy link
Member Author

raymondfeng commented Mar 5, 2019

@jannyHou @bajtos I created two commits for this PR:

  1. Improve openapi-spec-builder with new methods and add tests
  2. Set up operationId for controller routes

PTAL.

@raymondfeng raymondfeng requested a review from bajtos Mar 7, 2019

@raymondfeng raymondfeng force-pushed the add-operation-id branch from 2739977 to ff59689 Mar 11, 2019

@raymondfeng raymondfeng requested a review from bajtos Mar 11, 2019

@bajtos

bajtos approved these changes Mar 11, 2019

@raymondfeng raymondfeng merged commit 89f905b into master Mar 11, 2019

3 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@raymondfeng raymondfeng deleted the add-operation-id branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.