Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] feat(socketio): add support for Socket.IO to expose WebSocket endpoints #2648

Draft
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@raymondfeng
Copy link
Member

raymondfeng commented Mar 26, 2019

Starting to add SocketIOServer and explore how to decorate a controller to respond to corresponding events for incoming requests.

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@raymondfeng raymondfeng force-pushed the socketio branch 4 times, most recently from 423d70b to e10965b Mar 26, 2019

@bajtos

This comment has been minimized.

Copy link
Member

bajtos commented Mar 29, 2019

+1 to explore socket.io integration 馃憤

@raymondfeng to make review easier, can you treat this pull request as a spike please? It would be great to add _SPIKE_.md document to monorepo root and write down a high-level overview of the most important aspects of the implementation you are proposing.

@raymondfeng raymondfeng force-pushed the socketio branch from e10965b to 10bd814 Mar 29, 2019

@raymondfeng

This comment has been minimized.

Copy link
Member Author

raymondfeng commented Mar 29, 2019

@bajtos I started to add more information into the README.

@octisfall

This comment has been minimized.

Copy link

octisfall commented Apr 15, 2019

@raymondfeng npm install --save @loopback/socketio returns 404

@bajtos

This comment has been minimized.

Copy link
Member

bajtos commented Apr 18, 2019

I'd like to put this pull request on hold until we figure out how to approach experimental features - see #2676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.