Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type safety of function calls #2733

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@bajtos
Copy link
Member

commented Apr 12, 2019

This pull requests contains first two commits from #2704. The changes are needed to pass TypeScript's strictFunctionTypes check.

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

bajtos added some commits Apr 8, 2019

@bajtos bajtos requested a review from raymondfeng Apr 12, 2019

@bajtos bajtos self-assigned this Apr 12, 2019

@bajtos bajtos referenced this pull request Apr 12, 2019

Merged

feat(build): add more TypeScript "strict" checks #2704

4 of 4 tasks complete

@raymondfeng raymondfeng merged commit 9e7ea17 into master Apr 12, 2019

4 of 5 checks passed

coverage/coveralls Coverage decreased (-0.008%) to 91.231%
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@raymondfeng raymondfeng deleted the refactor/improve-type-safety-of-function-calls branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.