Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update errors/typo in hasOne page #2959

Merged
merged 1 commit into from May 25, 2019

Conversation

Projects
None yet
5 participants
@agnes512
Copy link
Contributor

commented May 24, 2019

resolves #2770

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@agnes512 agnes512 requested review from bajtos and raymondfeng as code owners May 24, 2019

@jannyHou
Copy link
Contributor

left a comment

馃憤 LGTM

@dhmlau

dhmlau approved these changes May 24, 2019

Copy link
Contributor

left a comment

I didn't try the code snippet, but the changes LGTM.

@agnes512 agnes512 merged commit 4a9e43b into master May 25, 2019

5 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 91.892%
Details

@agnes512 agnes512 deleted the hasOneDocFix branch May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.