Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to TypeScript 3.5 #2996

Merged
merged 1 commit into from May 30, 2019

Conversation

Projects
None yet
2 participants
@raymondfeng
Copy link
Member

commented May 30, 2019

Upgrade to TypeScript 3.5

I have to address a few breaking changes:

  1. microsoft/TypeScript#31661
  2. Generic type is default to unknown instead of {} now.

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@bajtos

bajtos approved these changes May 30, 2019

Copy link
Member

left a comment

LGTM

(EDITED) Please make sure the build is passing before merging.

@@ -98,7 +101,7 @@ describe('TodoController', () => {

describe('patch()', () => {
it('returns a number of todos updated', async () => {
patch.resolves([aChangedTodo].length);
patch.resolves({count: [aChangedTodo].length});

This comment has been minimized.

Copy link
@bajtos

bajtos May 30, 2019

Member

Nice! IIUC, the stricter type checks are detecting programming errors we were not aware of 馃憤

Show resolved Hide resolved packages/boot/src/__tests__/unit/booters/datasource.booter.unit.ts Outdated
@@ -100,7 +100,7 @@ describe('TodoController', () => {

it('uses the provided filter', async () => {
const find = todoRepo.stubs.find;
const filter: Filter = {where: {isCompleted: false}};
const filter: Filter<Todo> = {where: {isComplete: false}};

This comment has been minimized.

Copy link
@bajtos

bajtos May 30, 2019

Member

Nice! 馃憤

@bajtos bajtos referenced this pull request May 30, 2019

Merged

chore: update dependency typescript to v3.5.1 #138

0 of 1 task complete

@bajtos bajtos force-pushed the ts-3.5 branch from 9fce0cd to d92f661 May 30, 2019

@bajtos

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Fixed the problems in d92f661

@bajtos bajtos force-pushed the ts-3.5 branch from d92f661 to 1ccbeee May 30, 2019

@bajtos

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Rebased on top of the latest master, squashed the commits into a single one and force-pushed into the feature branch. Let's wait for CI results before landing.

@bajtos bajtos merged commit 0ec2266 into master May 30, 2019

4 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0007%) to 91.893%
Details

@bajtos bajtos deleted the ts-3.5 branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.