Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modelSettings is stringified properly #2915 #3015

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
2 participants
@marvinirwin
Copy link
Contributor

commented May 31, 2019

modelSettings is stringified ahead of time to prevent @settings([object object])

Fixes #2915, see also #2953

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@marvinirwin marvinirwin requested review from bajtos and raymondfeng as code owners May 31, 2019

@marvinirwin

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

This could have been prevented with a test that checks if a typescript file is syntactically valid. Is there a graceful way to do this? My first thought is the compiler api, but that's unstable.

@bajtos

bajtos approved these changes May 31, 2019

Copy link
Member

left a comment

Lovely 馃憦

Thank you @marvinirwin for the contribution 鉂わ笍

@bajtos

This comment has been minimized.

Copy link
Member

commented May 31, 2019

This could have been prevented with a test that checks if a typescript file is syntactically valid. Is there a graceful way to do this? My first thought is the compiler api, but that's unstable.

I guess we can execute npm run build in the scaffolded project? It's a rather heavy solution.

@bajtos bajtos self-assigned this May 31, 2019

@bajtos bajtos merged commit 84072ec into strongloop:master May 31, 2019

4 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 91.94%
Details
@bajtos

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Landed 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.