Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

discover uses owner instead of schema key #3115

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
2 participants
@marvinirwin
Copy link
Contributor

commented Jun 12, 2019

DiscoverModelNames used to return an array of {'table': 'foo', 'schema': 'bar'}, now the 'schema' key has been changed to 'owner'. This broke a part of the discover feature, this one-liner fixes it.

Fixes #3074

Looking at the refactors across the board, it seems the term "schema" has been changed to "owner" in this context. Should I do a follow-up PR which addresses this in the discover module?

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@marvinirwin marvinirwin requested review from bajtos and raymondfeng as code owners Jun 12, 2019

@marvinirwin marvinirwin force-pushed the marvinirwin:master branch from cefa495 to 66c231d Jun 12, 2019

@raymondfeng raymondfeng merged commit ed588b6 into strongloop:master Jun 12, 2019

4 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 91.765%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.