Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testlab): add `skipIf` helper #3138

Merged
merged 2 commits into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@bajtos
Copy link
Member

commented Jun 13, 2019

I discovered the need for a generic skipIf helper while working on #3079

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

bajtos added some commits Jun 13, 2019

feat(testlab): add `skipIf` helper
Signed-off-by: Miroslav Bajto拧 <mbajtoss@gmail.com>
docs(testlab): fix typos in README
Signed-off-by: Miroslav Bajto拧 <mbajtoss@gmail.com>

@bajtos bajtos requested a review from hacksparrow Jun 13, 2019

@bajtos bajtos requested a review from raymondfeng as a code owner Jun 13, 2019

@bajtos bajtos merged commit e2d852a into master Jun 13, 2019

4 of 5 checks passed

coverage/coveralls Coverage decreased (-0.04%) to 91.677%
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the feat/skip-if branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.