Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): add support for excluding custom pk from POST requests #3347

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@nabdelgadir
Copy link
Contributor

commented Jul 12, 2019

Closes #3344.

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@nabdelgadir nabdelgadir requested review from bajtos and raymondfeng as code owners Jul 12, 2019

@nabdelgadir nabdelgadir self-assigned this Jul 12, 2019

@nabdelgadir nabdelgadir force-pushed the custom-id branch 2 times, most recently from 71e035d to f2985f7 Jul 12, 2019

{
type: 'input',
name: 'id',
message: 'What is the ID property called?',

This comment has been minimized.

Copy link
@raymondfeng

raymondfeng Jul 12, 2019

Member

What's the name of ID property?

@nabdelgadir nabdelgadir force-pushed the custom-id branch 2 times, most recently from a2de978 to 5956e9e Jul 15, 2019

@nabdelgadir nabdelgadir added the CLI label Jul 15, 2019

@bajtos

bajtos approved these changes Jul 16, 2019

Copy link
Member

left a comment

LGTM 馃憦

In the future, it would be nice to parse TS source of the selected model to automatically infer primary key name and type. That's out of scope of this pull request though.

@bajtos bajtos added the feature label Jul 16, 2019

@nabdelgadir

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

@bajtos do you mean something similar to these two functions?

@nabdelgadir nabdelgadir force-pushed the custom-id branch from 5956e9e to 94bd8aa Jul 16, 2019

@nabdelgadir nabdelgadir force-pushed the custom-id branch from 94bd8aa to 323aa56 Jul 18, 2019

@nabdelgadir nabdelgadir merged commit 9694d99 into master Jul 18, 2019

4 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 91.525%
Details

@delete-merged-branch delete-merged-branch bot deleted the custom-id branch Jul 18, 2019

@nabdelgadir nabdelgadir added this to the July 2019 milestone milestone Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.