Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
RFC: Resolver for inclusion of related models #3387
In this pull request, I am proposing a solution for resolving inclusion of related models and demonstrating the viability of the proposed solution.
How to review this pull request:
Start by reading
Next, read through the code to see implementation details you are interested in:
@raymondfeng Thank you for a great feedback!
I pushed few commits to improve my proposal, I think all comments should be either addressed in code or answered here on GitHub.
Do you have any more suggestions? Does the proposed design & implementation LGTY now?
Can you please clarify what do you mean by updating repository package's README? I mean what kind of content would you like to see there? AFAICT, the current README does not describe relations at all.
+1 to show usage examples in the docs. At the moment, my proposal has the following sub-task for each relation type:
I'll expand that sub-tasks to cover examples of queries requesting inclusion of related models. Is that what you are asking for?
I have created the following follow-up stories.