Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(repository): add beginTransaction API #3397
I think I may get confused about your intention regarding how to structure the test suite.
My expectation was that you will simply add or more new files to packages/repository-tests/src/crud, because Transactions are specific to Crud repository interface - we don't support them for KeyValue repositories.
I see that you are creating a whole new transaction-only test suite. What's your reasoning for that? What benefits do you see in that approach?
I am concerned that if the transaction test suite requires a new test file in each per-connector acceptance package, it is difficult to discover by connector authors and makes it easy to forget to run it for certain connectors.
So far, my vision was to add new tests to the single CRUD suite, so that connector authors are notified about new features required by our ORM via a new test that may start failing for their connector.
The comments below are based on the assumption that transactions should be tested as part of our CRUD test suite.
I was doing it wrong :-). Thank you for the pointers, I agree with your POV.
2 times, most recently
Jul 23, 2019
@b-admike CI fails due to the following:
Yeah I am not sure how I'm dealing with
I think the coverage drop is because we don't run the transaction tests for all the downstream dependencies i.e.