Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(context): allow @bind to be applied on the same class multiple times #3618

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@raymondfeng
Copy link
Member

commented Aug 29, 2019

@bind({scope: BindingScope.TRANSIENT})
@bind({tags: {name: 'my-controller'}})
export class MyController {
}

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@raymondfeng raymondfeng requested a review from bajtos as a code owner Aug 29, 2019

@raymondfeng raymondfeng force-pushed the improve-bind-decorator branch from cee80f6 to 9d5e798 Aug 30, 2019

@bajtos
bajtos approved these changes Aug 30, 2019
Copy link
Member

left a comment

Nice, thank you @raymondfeng 馃憦

@bajtos bajtos merged commit ad4d22c into master Aug 30, 2019

4 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0006%) to 91.511%
Details

@bajtos bajtos deleted the improve-bind-decorator branch Aug 30, 2019

@bajtos bajtos referenced this pull request Aug 30, 2019
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.