Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document listenOnStart for REST servers #3891

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@raymondfeng
Copy link
Member

raymondfeng commented Oct 7, 2019

Document the feature introduced by #3879

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@raymondfeng raymondfeng requested a review from bajtos as a code owner Oct 7, 2019
@dhmlau dhmlau added the Docs label Oct 7, 2019
// Run the application
const config = {
rest: {
port: +process.env.PORT || 3000,

This comment has been minimized.

Copy link
@agnes512

agnes512 Oct 7, 2019

Contributor

an extra +?

This comment has been minimized.

Copy link
@raymondfeng

raymondfeng Oct 7, 2019

Author Member

No, + prefix converts the string into number.

@raymondfeng raymondfeng merged commit 819a660 into master Oct 7, 2019
5 checks passed
5 checks passed
Travis CI - Pull Request Build Passed
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 91.831%
Details
@raymondfeng raymondfeng deleted the listen-on-start-docs branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.