Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(core): improve states and add shutdown hooks for applications #4145
Inspired by https://github.com/godaddy/terminus
The PR improves the application lifecycle as follows:
@raymondfeng can you please beef up the pull request description and explain what new feature(s) you are adding, which use cases you are trying to address and how are the new features addressing them?
There is very little documentation in your code changes. Please find a way how to document the new behavior for users of our framework, we don't want them to grok the code or look up this pull request to understand your additions.
bajtos left a comment
I love the diagram you added, it makes it so much easier to understand the states and the transitions between them
I still feel we have too many states, which makes it more difficult for our users to understand how to write robust state observers, it's easy to accidentally forget to listen on all necessary events.
At the same time I'd like to move forward, I guess we will have to wait for user feedback and see how our LB developers are going to use this new feature (if at all).