Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] switch to TypeScript 3.7 optional chaining #4212

Merged
merged 2 commits into from Nov 28, 2019
Merged

[RFC] switch to TypeScript 3.7 optional chaining #4212

merged 2 commits into from Nov 28, 2019

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Nov 26, 2019 •
edited

See https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#optional-chaining

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@raymondfeng raymondfeng changed the title Optional chaining [RFC] switch to TypeScript 3.7 optional chaining Nov 26, 2019
@raymondfeng
feat(eslint-config): add typescript-eslint/prefer-optional-chain rule
6c45667 
BREAKING CHANGE: the `@typescript-eslint/prefer-optional-chain` rule will
report violations if optional chaining is not used. For example, it prefers
`options?.ttl` over `options && options.ttl`.

See https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#optional-chaining
@raymondfeng
chore: start to use TypeScript optional chaining
abc7941
@raymondfeng raymondfeng added breaking-change Internal Tooling Issues related to our tooling and monorepo infrastructore labels Nov 26, 2019
@raymondfeng raymondfeng merged commit 1de6e12 into master Nov 28, 2019
@raymondfeng raymondfeng deleted the optional-chaining branch November 28, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@emonddr emonddr emonddr approved these changes

Assignees
No one assigned
Labels
breaking-change Internal Tooling Issues related to our tooling and monorepo infrastructore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raymondfeng @bajtos @emonddr