Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove support for Node.js v8.x #4619

Merged
merged 1 commit into from Feb 11, 2020
Merged

chore: remove support for Node.js v8.x #4619

merged 1 commit into from Feb 11, 2020

Conversation

@raymondfeng
Copy link
Member

raymondfeng commented Feb 10, 2020

BREAKING CHANGE: Node.js v8.x is now end of life. Please upgrade to version
10 and above. See https://nodejs.org/en/about/releases.

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

BREAKING CHANGE: Node.js v8.x is now end of life. Please upgrade to version
10 and above. See https://nodejs.org/en/about/releases.
@dhmlau
dhmlau approved these changes Feb 11, 2020
@bajtos
bajtos approved these changes Feb 11, 2020
Copy link
Member

bajtos left a comment

馃憦

I appreciate the BREAKING CHANGE trailer in the commit message 馃憤

Once this PR is landed, we can review few RenovateBot PRs that were put on hold because the dependencies dropped support for Node.js 8.

@raymondfeng raymondfeng merged commit 4281d9d into master Feb 11, 2020
5 checks passed
5 checks passed
Travis CI - Pull Request Build Passed
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 92.483%
Details
@raymondfeng raymondfeng deleted the remove-node-8.x branch Feb 11, 2020
@derdeka derdeka mentioned this pull request Feb 19, 2020
0 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.