New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loopback 3 and loopback 4 buttons #795

Merged
merged 1 commit into from Jan 21, 2019

Conversation

Projects
None yet
6 participants
@nabdelgadir
Copy link
Contributor

nabdelgadir commented Jan 16, 2019

Connect to #786.

Added LoopBack 3 and LoopBack 4 buttons to website.

@nabdelgadir nabdelgadir requested a review from bschrammIBM as a code owner Jan 16, 2019

@nabdelgadir nabdelgadir force-pushed the promote branch from 7d9b43d to c0ab39c Jan 16, 2019

@dhmlau

This comment has been minimized.

Copy link
Contributor

dhmlau commented Jan 17, 2019

With the 2 buttons of LB3 and LB4, I think we can clean up the bottom part of the banner a bit. I'm thinking along the line of this:
screen shot 2019-01-17 at 1 06 39 pm

@bajtos @raymondfeng, from our discussion, I think you want to put some text around under what conditions that which version of LoopBack is recommended. I couldn't find a good way to capture that in the web site. Perhaps we should write a blog about it and have this web page pointing to it when it's ready? Thoughts?

@bajtos

This comment has been minimized.

Copy link
Member

bajtos commented Jan 18, 2019

Perhaps we should write a blog about it and have this web page pointing to it when it's ready?

+1

I think the blog post should not be a blocker for this pull request - we can land this PR first and then add the link to the blog post later.

@dhmlau

This comment has been minimized.

Copy link
Contributor

dhmlau commented Jan 18, 2019

Yes, that's what i meant too. If we're good with the proposal in #795 (comment) (the mockup), we can always add the blog link later.

@nabdelgadir

This comment has been minimized.

Copy link
Contributor Author

nabdelgadir commented Jan 18, 2019

Update: screen shot 2019-01-18 at 11 27 23 am

Thoughts?

@dhmlau

This comment has been minimized.

Copy link
Contributor

dhmlau commented Jan 18, 2019

LGTM.
@joesepi, what do you think? (since you originated this issue) :)

@dhmlau

dhmlau approved these changes Jan 18, 2019

@nabdelgadir nabdelgadir self-assigned this Jan 18, 2019

@b-admike
Copy link
Member

b-admike left a comment

Nice 💪

@jannyHou
Copy link
Contributor

jannyHou left a comment

LGTM :shipit:

@nabdelgadir nabdelgadir force-pushed the promote branch from 6554405 to b046a95 Jan 21, 2019

@nabdelgadir nabdelgadir merged commit e23b031 into gh-pages Jan 21, 2019

9 checks passed

Commit Linter commits are all properly formatted
Details
PR Linter PR is up to date
Details
[cis-jenkins] PR Builder Build finished.
Details
[cis-jenkins] x64 && linux && nvm,10 Success! (b046a95)
Details
[cis-jenkins] x64 && linux && nvm,8 Success! (b046a95)
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (StrongLoop) No new issues
Details
security/snyk - package.json (dhmlau) No new issues
Details

@nabdelgadir nabdelgadir deleted the promote branch Jan 21, 2019

@joesepi

This comment has been minimized.

Copy link
Member

joesepi commented Jan 22, 2019

Sorry for my delay in responding. Looks good, glad to see it implemented. Yay 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment