New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor authentication util functions into a service #40

Open
jannyHou opened this Issue Feb 1, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@jannyHou
Copy link
Contributor

jannyHou commented Feb 1, 2019

Description

We currently keep authentication related util functions in a util file, refactoring them into a service will give us the benefit of dependency injection.

The controller function calls the service to perform login. The service is injected via DI.
The login service receives UserRepository via DI.

Acceptance Criteria

  • Refactor the authentication related utils into a service class
  • The service is injected via DI in controller constructor, and controller function calls the service to perform login.
  • The UserRepository is injected via DI in service constructor.
  • Explorer better approach if the approach above is not the best practice

PR in progress

#33

@jannyHou jannyHou referenced this issue Feb 1, 2019

Open

Monthly Milestone - February 2019 💝⛄️ #2313

4 of 37 tasks complete

@dhmlau dhmlau added this to the February 2019 milestone milestone Feb 1, 2019

@dhmlau dhmlau added the TOB label Feb 7, 2019

This was referenced Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment