Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grpc support for recommender service #333

Merged
merged 3 commits into from Oct 24, 2019

Conversation

@raymondfeng
Copy link
Member

raymondfeng commented Oct 23, 2019

This is a spin-off from #268.

  1. Allow recommender service to expose gRPC endpoints
  2. Allow shopping to connect to recommender over gRPC and REST
@raymondfeng raymondfeng requested review from emonddr and jannyHou as code owners Oct 23, 2019
raymondfeng added 2 commits Aug 30, 2019
- improve recommendation service with rest and grpc
- fix user recommendation tests
- add support to invoke recommender using gRPC

Signed-off-by: Raymond Feng <enjoyjava@gmail.com>
Signed-off-by: Raymond Feng <enjoyjava@gmail.com>
Signed-off-by: Raymond Feng <enjoyjava@gmail.com>
Copy link

agnes512 left a comment

LGTM in high-level :D

@raymondfeng raymondfeng merged commit 49b96b1 into master Oct 24, 2019
3 checks passed
3 checks passed
DCO DCO
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@raymondfeng raymondfeng deleted the grpc branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.