Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tidy up tests and make datasources compatible with kubernetes deployment #338

Merged
merged 3 commits into from Oct 25, 2019

Conversation

@raymondfeng
Copy link
Member

raymondfeng commented Oct 24, 2019

Spin-off from #268

  1. Improve tests to avoid side-efforts (make sure setup code to execute in mocha hooks)
  2. Make sure datasources are disconnected upon app.stop
  3. Add logic to *.datasources.ts to accept configuration from env vars by kubernetes
@raymondfeng raymondfeng requested review from emonddr and jannyHou as code owners Oct 24, 2019
@raymondfeng raymondfeng force-pushed the tidy-up-datasources branch from ac0bb3a to fe0688f Oct 24, 2019
@dhmlau
dhmlau approved these changes Oct 24, 2019
Copy link
Collaborator

dhmlau left a comment

I don't have deep understanding on the impact of the code change, but it looks reasonable to me. Please make sure you can at least one more reviews before merging. Thanks!

raymondfeng added 3 commits Sep 2, 2019
- make datasources aware of kubernetes deployment
- detect k8s and use environment variables to set up datasources
- enable lifecycle support for datasources

Signed-off-by: Raymond Feng <enjoyjava@gmail.com>
Signed-off-by: Raymond Feng <enjoyjava@gmail.com>
Signed-off-by: Raymond Feng <enjoyjava@gmail.com>
@raymondfeng raymondfeng force-pushed the tidy-up-datasources branch from fe0688f to 955bd04 Oct 24, 2019
@@ -0,0 +1,60 @@
#!/usr/bin/env node

This comment has been minimized.

Copy link
@emonddr

emonddr Oct 25, 2019

Contributor

@raymondfeng , why do we need to rebuild package locks?
Is this a script we should make available to anyone building an LB4 app?

This comment has been minimized.

Copy link
@raymondfeng

raymondfeng Oct 25, 2019

Author Member

The shopping project is set up as a lerna monorepo and it requires a few steps to rebuild package-lock files.

@raymondfeng raymondfeng merged commit ce47a7b into master Oct 25, 2019
3 checks passed
3 checks passed
DCO DCO
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@raymondfeng raymondfeng deleted the tidy-up-datasources branch Oct 25, 2019
Copy link
Contributor

jannyHou left a comment

👍 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.