Support disabling CORS by setting config value to false #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
@slnode ok to test |
|
Hi @claylo, thank you for the pull request. The proposed implementation is sub-optimal as it unnecessarily adds a middleware handler that is effectively a no-op. A better solution is to not add the middleware handler at all (see the line |
|
Hi @claylo, what's the status of this pull request, are you still keen to finish it up? |
|
I have fixed the remaining issues, reworked the commit message to follow the 50/72 rule and landed the patch. Thank you @claylo for the contribution. |
|
Thank you, @bajtos -- sorry about the mess with the rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORS headers may be enabled/handled elsewhere in the application stack, so strong-remoting should support the ability to turn its internal use of CORS off entirely.
See strongloop/loopback#575