Rest-adapter errorHandler set content-type json
#390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
reviewed
Dec 7, 2016
| @@ -210,6 +210,24 @@ describe('strong-remoting-rest', function() { | |||
| .end(done); | |||
| }); | |||
|
|
|||
| it('should use `content-type: application/json` for default errorHandler', | |||
There was a problem hiding this comment.
Could you please add a comment before this test case with a link to the github issue this test is reproducing?
bajtos
reviewed
Dec 7, 2016
|
|
||
| request(app).get(method.url) | ||
| .expect(500) | ||
| .expect('content-type', 'application/json; charset=utf-8', function(err) { |
There was a problem hiding this comment.
You can simplify this line:
.expect('content-type', '...', done);
bajtos
approved these changes
Dec 7, 2016
the defaultHandler always res.sends an object therefore make sense to always set response header as such
davidcheung
force-pushed
the
rest-errorhandler-contenttype
branch
from
5ff91d9
to
e844ae6
Compare
|
@slnode test please |
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the defaultHandler always res.sends an object
therefore make sense to always set response header as such
related to strongloop/loopback-component-storage#179